Repository navigation
test(ffe): enable PHP agentless EVP egress coverage - #8476
Draft
leoromanovsky wants to merge 2 commits into
Draft
leoromanovsky wants to merge 2 commits into
leoromanovsky wants to merge 2 commits into
Conversation
Contributor
|
|
2 tasks
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 4 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 7f153aa | Docs | View more details | Give us feedback! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PHP customers using agentless flags also need exposure and evaluation-count delivery when no Datadog Agent is present. Activate the shared egress contracts for dd-trace-php #4489. This PR is stacked on #8475; merge the PHP implementation before relying on its development-version gate.
Changes
Enable exposures and evaluation counts in both the direct-intake and serverless-init scenarios from
v1.28.0-dev, preserving the Laravel/Symfony test-app exclusions. Replace the file-wide evaluation-test exclusion with sibling-class exclusions so the two enabled classes actually run and unsupported cases keep their gates.For the direct scenario, launch Apache or PHP-FPM in the foreground so the existing live topology assertion proves the application server owns PID 1 and no Agent or init wrapper is present. Extend the server-name contract with PHP and add controls rejecting shell, tail, and similarly named wrappers. The separate shutdown test remains disabled because the PHP app does not emit its required server-close marker.
Local Apache/PHP 8.2.35 validation used PHP
7aecaffffac9:FEATURE_FLAGGING_AND_EXPERIMENTATION_AGENTLESS_DIRECTFEATURE_FLAGGING_AND_EXPERIMENTATION_AGENTLESS_SERVERLESSFEATURE_FLAGGING_AND_EXPERIMENTATION_AGENTLESS_EXPLICITThe installed extension SHA-256 was
c86d733862228766c237d4df1e5e9ba61b71955ad1c03177c3b6d529d6fd4981. The local PHP build reports 1.27.0, so these runs used the supported-Foverride; 60 separate manifest checks verified effective activation across old/development versions and Apache, ZTS, FPM, Laravel, and Symfony variants. All unsupported evaluation classes remain gated. The 53 FFE harness tests and./format.shpassed. These are local controlled-service results; PHP-FPM and staging were not exercised.Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟